Enable HTML5 markup snippet change

Community Forums Forums General Discussion Enable HTML5 markup snippet change

This topic is: not resolved

Tagged: 

This topic contains 5 replies, has 2 voices, and was last updated by  David Chu 8 months, 3 weeks ago.

Viewing 6 posts - 1 through 6 (of 6 total)
  • Author
    Posts
  • #97596

    RobCubbon
    Participant
    Post count: 105

    Hey,

    I converted my sites to HTML5 a while back last year when Genesis 2.0 came out (was that last year? I’m guessing)

    I did so with this code in the functions.php

    
    // Enable HTML5 markup
    add_theme_support( 'html5' );
    

    Now, I notice it has changed: https://gist.github.com/studiopress/6173486#file-functions-php to :

    
    //* Add HTML5 markup structure
    add_theme_support( 'html5', array( 'search-form', 'comment-form', 'comment-list' ) );
    

    Should I change it? What’s the benefit of the change?

    I would be grateful for any help with this.


    http://robcubbon.com
    #97683

    David Chu
    Participant
    Post count: 1426

    Hi Rob!
    An interesting question! I had not seen that snippet. I’m not sure of the answer, but I did some digging. Current Genesis core has it the first (non-parm) way.

    Yet if you go to the Codex, current 3.8.1 code tells you to do it the second way in its comments.

    http://codex.wordpress.org/Function_Reference/add_theme_support#HTML5

    … and below that, you can find a source link that shows the bare code.

    My guess would be that the Genesis code may be eventually updated to do it the new official way. It seems to be working fine the old way for now. Maybe somebody else here knows, or I wonder if you might want to ask some of the super techie Genesis folks on Twitter, like Gary or Nathan Rice.

    Cheers, Dave


    Dave Chu · Custom WordPress Developer – likes collaborating with Designers

    #97765

    RobCubbon
    Participant
    Post count: 105

    Hey Dave, nice to talk to you again. I’ve tweeted it out to Nathan Rice (I hope that’s OK).


    #97771

    David Chu
    Participant
    Post count: 1426

    Rob,
    Always good to see you! If you have a sec, let me know what you find out. (on Twitter is fine)

    :-)


    Dave Chu · Custom WordPress Developer – likes collaborating with Designers

    #97814

    RobCubbon
    Participant
    Post count: 105

    Dave, Nathan just tweeted me “use the parameters. It’s how WP 3.9 will expect it to be used, though it won’t break if you just use the ‘html5′ part.”

    https://twitter.com/nathanrice/status/450783417589047296

    I guess I’d better change it on my sites then :)


    #97828

    David Chu
    Participant
    Post count: 1426

    Rob,
    Thanks for the head’s up! My psychic powers must have been on today.

    Dave


    Dave Chu · Custom WordPress Developer – likes collaborating with Designers

Viewing 6 posts - 1 through 6 (of 6 total)

You must be logged in to reply to this topic.