Community Forums › Forums › Archived Forums › General Discussion › Testing Genesis 2.0 beta on dev site
- This topic has 16 replies, 2 voices, and was last updated 10 years, 9 months ago by RobCubbon.
-
AuthorPosts
-
June 10, 2013 at 5:56 pm #45140RobCubbonMember
Hello, Apologies is this is the wrong place for this question.
I want to see if my site works on Genesis 2.0 so I'm making a copy of the site on a subdomain dev.mysite.com – for example.
Once I make the copy what do I do as there will be no way to update Genesis?
Do you simply delete wp-content/themes/genesis and replace it with the 2.0 beta copy downloaded from My Studiopress?
June 10, 2013 at 7:26 pm #45151rfmeierMemberHello,
I would recommend using the Genesis Beta Tester Plugin. This way you don't have to worry about uploading versions.
June 11, 2013 at 3:53 am #45197RobCubbonMemberHello refmeier, that was so useful because I didn't know about that plugin.
I'm testing a site in Genesis 2.0 beta and, after updating the framework, the site looks and behaves exactly the same.
However I notice the HTML starts with
!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"
That's not HTML5 is it? Am I missing something?
June 11, 2013 at 5:34 am #45205rfmeierMemberRob,
I believe you will need to add a line of code first. Try this;
http://www.briangardner.com/code/add-html5-markup/
June 11, 2013 at 5:46 am #45208RobCubbonMemberThanks again, rfmeier. I'm sorry, I assumed Genesis 2.0 was HTML5 by default.
I have added the HTML5 mark up and it has caused structural issues to the site (as I expected it would). So is it a case of looking at http://www.briangardner.com/code/genesis-html5-markup/ <-- this link, and going through the CSS and changing a few of the descriptors?
do you know of a post that helps with this?
June 11, 2013 at 5:50 am #45210rfmeierMemberRob,
No need to apologize. Here is a post by StudioPress summarizing recent Genesis 2 resources;
http://www.studiopress.com/news/genesis-2-0-resources.htm
There is a stylesheet converter out there somewhere, but I am not able to find it right now.
June 11, 2013 at 6:24 am #45222RobCubbonMemberJune 11, 2013 at 6:26 am #45224rfmeierMemberYou are welcome.
That may be it. I see you are on Twitter. Check the #genesiswp list. I think I saw it floating around there, but I think you have found it.
June 11, 2013 at 7:07 am #45231RobCubbonMemberJune 12, 2013 at 7:38 am #45425RobCubbonMemberActually, I've stumbled on a big problem whilst changing a site from xhtml to html5 (let me know if I should start a new thread for this).
I have a custom page with the following widgets:
`
function cre8tive_front_genesis_meta() {
if ( is_active_sidebar( 'home-title' ) ) {
remove_action( 'genesis_loop', 'genesis_do_loop' );
add_action( 'genesis_loop', 'cre8tive_home_left' );
add_action( 'genesis_loop', 'cre8tive_home_middle' );
add_action( 'genesis_loop', 'cre8tive_home_right' );add_filter( 'body_class', 'add_body_class' );
function add_body_class( $classes ) {
$classes[] = 'cre8tive-front';
return $classes;
}}
}function cre8tive_home_left() {
if ( is_active_sidebar( 'home-left' ) ) {
genesis_widget_area( 'home-left', array(
'before' => '',
) );
}}
function cre8tive_home_middle() {
if ( is_active_sidebar( 'home-middle' ) ) {
genesis_widget_area( 'home-middle', array(
'before' => '',
) );
}}
function cre8tive_home_right() {
if ( is_active_sidebar( 'home-right' ) ) {
genesis_widget_area( 'home-right', array(
'before' => '',
) );
}}
`
This created three separate div classes that I could style up with no problem.
After the change to HTML5 these divs have all been put inside each other! It's like there's been too many closing divs put in.
Anyone experienced this before?
June 12, 2013 at 7:42 am #45426RobCubbonMemberI've just put both pages through HTML Validator
xhtml got 2 errors and 1 warning. html5 got 12 Errors and 2 warnings
The extra errors were "Unclosed element div" and "Stray end tag aside".
June 12, 2013 at 8:08 am #45434rfmeierMemberRob,
I checked the Genesis 2.0 source. Here are the default args for the genesis_widget_area function;
$args = wp_parse_args( $args, array( 'before' => genesis_html5() ? '<aside class="widget-area">' : '<div class="widget-area">', 'after' => genesis_html5() ? '</aside>' : '</div>', 'default' => '', 'show_inactive' => 0, 'before_sidebar_hook' => 'genesis_before_' . $id . '_widget_area', 'after_sidebar_hook' => 'genesis_after_' . $id . '_widget_area', ) );
I noticed your code was specifying the 'before' as an empty string. Try removing that option and see if it helps.
June 12, 2013 at 8:40 am #45442RobCubbonMemberActually, Ryan, the 'before' isn't empty. It's just been stripped out here for some reason and I didn't notice.
They are all like this:
`
'before' => ' LESSTHAN div class="home-title widget-area" GREATERTHAN ',
`I probably should be using paste-bin here
June 12, 2013 at 8:49 am #45451rfmeierMemberRob,
I see, but that also explains more. You are specifying a div as the opening, but since you are withing geneis 2.0 (html5), it is closing it with an html5 tag (aside).
Try using an aside instead of a div.
I hope this helps.
June 12, 2013 at 9:00 am #45464RobCubbonMemberAhhh, that's it, Ryan. Thank you so much. I should have worked that out from the HTML but I thought it was something else.
I need to find out more about these new HTML5 tags and what they mean.
But at least we've got a really easy way to turn an old XHTML Genesis site into a new HTML5 one 🙂
June 12, 2013 at 9:02 am #45465rfmeierMemberYou are welcome.
I have days where I spend way too much time (hours) on an issue only to have someone walk over and point it out in 30 seconds.
This is why authors don't proof-read their own work.
June 12, 2013 at 9:04 am #45467RobCubbonMember -
AuthorPosts
- The forum ‘General Discussion’ is closed to new topics and replies.