jb510

Forum Replies Created

Viewing 15 posts - 1 through 15 (of 17 total)
  • Author
    Posts

  • jb510
    Participant
    Post count: 10

    I’m fine with having priorities. I saw an elegance to not having priorities in genesis core since it meant I didn’t have to think about where to unhook things from. I could just unhook it and add it back with a priority. This did sometimes mean unhooking multiple actions to squeeze someone in between, but as Gary said there are positives and negatives either way.

    In practice I have a code snippet of the loop resets and just drop that in then whittle it down to the few I need to move/replace.

    Side note: seems like a framework function to move things might be handy, although maybe not considering what i just came up with in my head for it looks maybe harder to read then the standard remove/add combo. move_action(array($function,$hook,$priority),array($funtion, $hook, $priority)
    or
    move_action(array(
    array($function,$hook,$priority),array($funtion, $hook, $priority)),
    array($function,$hook,$priority),array($funtion, $hook, $priority))
    )



    jb510
    Participant
    Post count: 10

    Thanks Gary. Bill chimed in too elsewhere. I appreciate both explanations.

    The thing is, I totally understand WHY these changes were made, it was pretty obvious once I found and looked at the actual changes. It also makes total sense to make those changes now. What I don’t get is not putting out a single note about those changes before dropping 2.0 on folks.

    I heard rumors about the genesis-html > html change and the .navigation > .pagination change so neither of those caught me too off guard but the hook changes hit me completely out of the blue.

    I’m sure I wasn’t alone in making the assumption after the tiny changes between RC1 and RC2 that Final wouldn’t totally fubar things. It’s crying over spilt milk at this point, but a little heads up would have been nice. It would have made the difference between fixing things in a “holy crap why is this !@$#@! broken” mode rather than “Oh, I need to fix these 5 little things before updating” mode. Obviously the former isn’t pleasant and here could have totally been avoided.



    jb510
    Participant
    Post count: 10

    Bill to the rescue, hadn’t seen that. It’s neater than what I wrote up here:

    I wrote this up: http://www.wanderingjon.com/2013/08/07/breaking-change-from-genesis-2-0-release-candidate-2-to-final/



    jb510
    Participant
    Post count: 10

    More changes between RC2 and final… Hooks got explicit priorities instead of all being on 10 and falling down in order (which was way easier to unhook):

    For example
    add_action( ‘genesis_entry_header’, ‘genesis_post_info';
    is now
    add_action( ‘genesis_entry_header’, ‘genesis_post_info’, 12 );

    Hence to remove it you need the priority:
    remove_action( ‘genesis_entry_header’, ‘genesis_post_info’, 12 );

    same for:
    remove_action( ‘genesis_entry_header’, ‘genesis_do_post_format_image’, 4 );
    remove_action( ‘genesis_entry_content’, ‘genesis_do_post_image’, 8 );
    remove_action( ‘genesis_entry_content’, ‘genesis_do_post_content_nav’, 12 );
    remove_action( ‘genesis_entry_content’, ‘genesis_do_post_permalink, 14 );
    remove_action( ‘genesis_after_entry’, ‘genesis_do_author_box_single’, 8 );


    in reply to: Eleven40 Theme: Featured Posts Not Using Theme CSS #50275

    jb510
    Participant
    Post count: 10

    Kat,

    You probabaly want to add this CSS:

    
    .footer-widgets .featuredpost h2 a {
    color: #CC6600;
    font-family: Lora;
    text-decoration: none;
    }
    
    .footer-widgets .featuredpost h2 {
    padding: 4px 0 5px;
    }
    
    .footer-widgets .featuredpost .post {
    border-bottom: 1px solid #444;
    padding: 2px 0;
    }
    
    

    The issue is that the featured post widget is wrapping those link in an h2 tag.


    in reply to: Reporting a bug in Genesis 1.9.1 #34908

    jb510
    Participant
    Post count: 10

    Yay!  Genesis 1.9.2 fixes this.


    in reply to: Reporting a bug in Genesis 1.9.1 #32399

    jb510
    Participant
    Post count: 10

    So again…  any update on this as it’s still not fixed to WP core, or Genesis?  It sounds like it was fixed in Genesis trunk but still almost 2 months later not released?  Could we at least get a patch to Genesis published?

     


    in reply to: Reporting a bug in Genesis 1.9.1 #24738

    jb510
    Participant
    Post count: 10

    Any word on releasing this fix? I just spent an hour tracking it down only to find out it was found and fixed 6 weeks ago, just not released :(



    jb510
    Participant
    Post count: 10

    Thanks to @GaryJ I figured this out.

    [php]<code>
    /**
    * jb_modify_post_image
    *
    * Changes featured image size for white paper
    */
    function jb_modify_post_image( $image_size ) {
    if ( ‘jb_whitepaper’ === get_post_type()) {
    $image_size = ‘jb_whitepaper_featured';
    }
    return $image_size;
    }
    add_filter( ‘genesis_pre_get_option_image_size’, ‘jb_modify_post_image’ );
    </code>
    [/php]


    in reply to: Eleven40 header customization #1507

    jb510
    Participant
    Post count: 10

    If you’re looking for the easiest way to do this, just remove the header parts you don’t want and add the logo to the sidebar widget area (text widget with <img src=….> in it)

    If you’re look for a better way to do it, I’d  try unhooking the header and reattaching it to genesis_before_sidebar_alt_widget_area and then cleaning up the CSS to accomodate.

    Better still would to keep the header outside the #sidebar-alt div but you’re still talking about moving the structure around quite a bit.


    in reply to: Forum Bugs and Issues #222

    jb510
    Participant
    Post count: 10

    One more minor thing…  looking at the bbPress search results they come up full content which, IMHO, probably isn’t the best way to display results.

    http://www.studiopress.com/forums/?s=css

    It’s hard to tell where one entry starts and stops, I thought at first it was just on post coming up.   Adding post-info below the titles might make it visually more obvious…  and/or switching to excerpts.

    Besides that, I usually install http://wordpress.org/extend/plugins/search-bbpress/ on bbPress forums…  much better search results that way.


    • This reply was modified 2 years, 1 month ago by  jb510.
    • This reply was modified 2 years, 1 month ago by  jb510.
    in reply to: Forum Bugs and Issues #221

    jb510
    Participant
    Post count: 10

    @Brian – I usually use SyntaxHighlghter Evolved: http://wordpress.org/extend/plugins/syntaxhighlighter/

    Crayon is good too: http://wordpress.org/extend/plugins/crayon-syntax-highlighter/

    but I’ve never used either inside bbPress…

     


    in reply to: Forum Bugs and Issues #219

    jb510
    Participant
    Post count: 10

    @Brian – Sorry poorly worded.  On the old forums there was code syntax highlighting enabled on code snippets.

    Old example: http://www.studiopress.com/support/showpost.php?p=474316&postcount=6

    New example: http://www.studiopress.com/forums/topic/using-jquery-isotope/#post-147

    In the old example you can see the PHP gets syntax highlighting.


    in reply to: Suggestion: Sorting of downloads #209

    jb510
    Participant
    Post count: 10

    I had the same thought.  I might need to make a picture but my thoughts…

    The “Type” column is worthless as-is and should be the contents of the “Type” column should be icons/badges representing “Blog/CMS/Responsive/E-Commerce”.  Whatever the key features you categorize themes by.

    Then group StudioPress and Community Themes separately like this:

    Crud…  tables won’t work…  can’t attach an image…

    Alright edit 3, lets try a link:

    http://www.evernote.com/shard/s35/sh/33387d5c-8e63-45f0-922b-355bd41bc12b/5da269f38c7f45fc291e4c869c8cac3f


    • This reply was modified 2 years, 1 month ago by  jb510.
    • This reply was modified 2 years, 1 month ago by  jb510.
    • This reply was modified 2 years, 1 month ago by  jb510.
    • This reply was modified 2 years, 1 month ago by  jb510.
    • This reply was modified 2 years, 1 month ago by  jb510.
    • This reply was modified 2 years, 1 month ago by  jb510.
    in reply to: Forum Bugs and Issues #207

    jb510
    Participant
    Post count: 10

    Could code syntax highlighting love get added to inline code block here?


Viewing 15 posts - 1 through 15 (of 17 total)